Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated default bpo for cens #1192

Merged
merged 1 commit into from Jun 26, 2020
Merged

updated default bpo for cens #1192

merged 1 commit into from Jun 26, 2020

Conversation

bmcfee
Copy link
Member

@bmcfee bmcfee commented Jun 26, 2020

Reference Issue

Fixes #1191
Fixes #1170

What does this implement/fix? Explain your changes.

This PR changes the default bins-per-octave for CENS to match chroma_cqt, following #1170

Any other comments?

The documentation has not been updated here, to avoid conflicts with WIP #1178 .

No CR needed, will merge once CI passes. After that, I'll rebase #1178 and finish the documentation update.

@bmcfee bmcfee added bug Something doesn't work like it should API change Does this change the behavior of existing API? labels Jun 26, 2020
@bmcfee bmcfee added this to the 0.8.0 milestone Jun 26, 2020
@bmcfee bmcfee self-assigned this Jun 26, 2020
@bmcfee bmcfee merged commit f8fb3ee into main Jun 26, 2020
@bmcfee bmcfee deleted the cens-default-bpo branch June 26, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change Does this change the behavior of existing API? bug Something doesn't work like it should
Development

Successfully merging this pull request may close these issues.

CENS default bins-per-octave should match chroma_cqt Change default bins_per_octave in chroma_cqt?
1 participant