Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced the broken url for Sphinx and Matplotlib in CONTRIBUTING.md #1284

Merged
merged 1 commit into from Feb 16, 2021
Merged

Replaced the broken url for Sphinx and Matplotlib in CONTRIBUTING.md #1284

merged 1 commit into from Feb 16, 2021

Conversation

Abduttayyeb
Copy link
Contributor

Replaced the broken url links in CONTRIBUTING.md for
-Sphinx Webpage
-Matplotlib Webpage
on the line 117 and 118

bmcfee
bmcfee approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@bmcfee bmcfee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching these!

@bmcfee bmcfee added the documentation Issues relating to docstrings, examples, and documentation build label Feb 16, 2021
@bmcfee bmcfee added this to the 0.8.1 milestone Feb 16, 2021
@bmcfee
Copy link
Member

bmcfee commented Feb 16, 2021

Is there anything else to add here, or are we good to merge?

@Abduttayyeb
Copy link
Contributor Author

Is there anything else to add here, or are we good to merge?

Yeaa sure, i can't find anything else to update in CONTRIBUTING.md

@bmcfee
Copy link
Member

bmcfee commented Feb 16, 2021

Great. Thanks again!

@bmcfee bmcfee merged commit 790690c into librosa:main Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmcfee bmcfee bmcfee approved these changes

Assignees
No one assigned
Labels
documentation Issues relating to docstrings, examples, and documentation build
Milestone
0.8.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Abduttayyeb @bmcfee