Add ffmpeg link for windows #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing gstreamer and pygobject on windows is a lot of pain, it turns out installing ffmpeg is a lot easier. Adding a link for ffmpeg and I hope it will save someone some pain.
bmcfee
added
the
documentation
|
Thanks for this, but I'm a bit puzzled. The link we had (gstreamer.freedesktop.org) already included binaries, so why do we need a second link? |
|
I just couldn't get pygobject to install on Windows, but for ffmpeg I downloaded the binaries and added them to path and that was it. Am I missing something? The new link is for ffmpeg. |
|
Ah, sorry about that -- I read too quickly. This LGTM, thanks! |
bmcfee
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing gstreamer and pygobject on windows is a lot of pain, it turns out installing ffmpeg is a lot easier. Adding a link for ffmpeg and I hope it will save someone some pain.
Reference Issue
What does this implement/fix? Explain your changes.
Any other comments?