Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trying to fix some CI issues #1308

Merged
merged 5 commits into from Apr 14, 2021
Merged

trying to fix some CI issues #1308

merged 5 commits into from Apr 14, 2021

Conversation

bmcfee
Copy link
Member

@bmcfee bmcfee commented Apr 13, 2021

Reference Issue

#1307

What does this implement/fix? Explain your changes.

Forcing sndfile installation on travis, and trying to update appveyor so that image tests work again.

Any other comments?

@bmcfee
Copy link
Member Author

bmcfee commented Apr 14, 2021

Python 3.8 issue stems from libsndfile not being packaged on mainline conda for python 3.8 (?!). It's not a python package, so I don't see why this is the case, but perhaps we can work around it by forcing from conda-forge.

@bmcfee
Copy link
Member Author

bmcfee commented Apr 14, 2021

The appveyor issue is also tricky.

Although we force installation of freetype>=2.10 (and this indeed works), the matplotlib build seems to be linked against freetype 2.6. This is ultimately the source of the image comparison failures, as the two versions differ by just enough to through off the RMS calculations.

Since fixing this would probably require rebuilding matplotlib on our appveyor instance (which seems costly and not worth it), I propose that we simply bypass the image comparison tests (or mark as allowed to fail) if matplotlib's freetype version is below 2.10. This is probably a good fix anyway, as it makes explicit the requirements for running the tests relative to the environment in which i created the original fixtures.

@bmcfee bmcfee added management Project governance, packaging, distribution, etc Upstream/dependency bug Another package is causing us trouble! labels Apr 14, 2021
@bmcfee bmcfee added this to the 0.8.1 milestone Apr 14, 2021
@bmcfee bmcfee self-assigned this Apr 14, 2021
@bmcfee
Copy link
Member Author

bmcfee commented Apr 14, 2021

Forcing conda-forge on travis sort of works -- libsndfile is now installed in the environment. However, the soundfile package can't find it, and the tests still fail. I'm pretty flummoxed at this point.

@bmcfee
Copy link
Member Author

bmcfee commented Apr 14, 2021

Update: installing libsndfile1 via apt fixes this. It's not a great fix, in that the sndfile packaging is still kinda broken, but at least it gets that issue out of our way.

Will merge once all outstanding builds finish.

@bmcfee bmcfee merged commit 2ea91af into main Apr 14, 2021
@bmcfee bmcfee deleted the ci-fixes branch April 14, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
management Project governance, packaging, distribution, etc Upstream/dependency bug Another package is causing us trouble!
Development

Successfully merging this pull request may close these issues.

None yet

1 participant