Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.4.3 #349

Merged
merged 4 commits into from
May 17, 2016
Merged

Release 0.4.3 #349

merged 4 commits into from
May 17, 2016

Conversation

bmcfee
Copy link
Member

@bmcfee bmcfee commented May 4, 2016 •
edited
Loading

Implements #336

This change is Reviewable

@bmcfee bmcfee added documentation Issues relating to docstrings, examples, and documentation build management Project governance, packaging, distribution, etc labels May 4, 2016
@bmcfee bmcfee added this to the 0.4.3 milestone May 4, 2016
@bmcfee
Copy link
Member Author

bmcfee commented May 4, 2016

Note @stefan-balke : pylint caught that the threshold parameter in chroma_cens wasn't being used. I've removed this for now -- we can add it back in when normalization updates are reintroduced.

@bmcfee bmcfee force-pushed the release-043 branch 2 times, most recently from 8e14175 to 42eb0cd Compare May 9, 2016 13:27
@bmcfee bmcfee force-pushed the release-043 branch 2 times, most recently from 1025617 to 657b960 Compare May 13, 2016 03:08
@bmcfee
Copy link
Member Author

bmcfee commented May 15, 2016

Reviewed 9 of 10 files at r1, 8 of 8 files at r2.
Review status: 17 of 18 files reviewed at latest revision, 1 unresolved discussion.

librosa/version.py, line 6 [r2] (raw file):

short_version = '0.4'
version = '0.4.3rc0'

Before merge: set this to 0.4.3.

Comments from Reviewable

@bmcfee
removed scikits.samplerate from docs
b3f9cc7 
updated changelog
@bmcfee
updated urls to point to librosa org
5fb27a2 
updated changelog

updated docs and contributors

updated version number
@bmcfee
Copy link
Member Author

bmcfee commented May 17, 2016

Review status: 17 of 18 files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

librosa/version.py, line 6 [r2] (raw file):

Previously, bmcfee (Brian McFee) wrote…

Before merge: set this to 0.4.3.


Done.

Comments from Reviewable

@bmcfee
Copy link
Member Author

bmcfee commented May 17, 2016

Review status: 17 of 18 files reviewed at latest revision, 1 unresolved discussion.

librosa/version.py, line 6 [r2] (raw file):

Previously, bmcfee (Brian McFee) wrote…

Done.


Done.

Comments from Reviewable

@bmcfee
Copy link
Member Author

bmcfee commented May 17, 2016

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

@bmcfee bmcfee merged commit 4467088 into master May 17, 2016
@bmcfee bmcfee deleted the release-043 branch May 17, 2016 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Issues relating to docstrings, examples, and documentation build management Project governance, packaging, distribution, etc
Milestone
0.4.3
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@bmcfee