Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robust softmask #357

Merged
merged 3 commits into from May 15, 2016
Merged

robust softmask #357

merged 3 commits into from May 15, 2016

Conversation

bmcfee
Copy link
Member

@bmcfee bmcfee commented May 15, 2016

Implements #356

To-do:


This change is Reviewable

@bmcfee bmcfee self-assigned this May 15, 2016
@bmcfee bmcfee added enhancement Does this improve existing functionality? functionality Does this add new functionality? labels May 15, 2016
@bmcfee bmcfee added this to the 0.4.3 milestone May 15, 2016
updated docstrings
docstring updates
@bmcfee bmcfee changed the title [WIP] robust softmask robust softmask May 15, 2016
@bmcfee
Copy link
Member Author

bmcfee commented May 15, 2016

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


librosa/util/utils.py, line 1445 [r1] (raw file):

    else:
        # Otherwise, compute the hard mask
        mask = X > X_ref

Note: this isn't symmetric in the arguments, since elements with equal energy in both inputs will receive mask=0; that is, ties are always broken in favor of the reference (for hard-masking).


Comments from Reviewable

@bmcfee
Copy link
Member Author

bmcfee commented May 15, 2016

Review status: all files reviewed at latest revision, 1 unresolved discussion.


librosa/util/utils.py, line 1445 [r1] (raw file):

Previously, bmcfee (Brian McFee) wrote…

Note: this isn't symmetric in the arguments, since elements with equal energy in both inputs will receive mask=0; that is, ties are always broken in favor of the reference (for hard-masking).


Done.


Comments from Reviewable

@bmcfee
Copy link
Member Author

bmcfee commented May 15, 2016

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@bmcfee bmcfee merged commit ce40969 into master May 15, 2016
@bmcfee bmcfee deleted the robust-softmask branch May 15, 2016 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Does this improve existing functionality? functionality Does this add new functionality?
Development

Successfully merging this pull request may close these issues.

None yet

1 participant