Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed util.SMALL_FLOAT #372

Merged
merged 4 commits into from
Jun 9, 2016
Merged

Removed util.SMALL_FLOAT #372

merged 4 commits into from
Jun 9, 2016

Conversation

bmcfee
Copy link
Member

@bmcfee bmcfee commented Jun 9, 2016 •
edited
Loading

And replaced by calling np.finfo(dtype).tiny, which is a more precise and less arbitrary way to accomplish what we need from the SMALL_FLOAT constant.

fixes #358

This change is Reviewable

@bmcfee bmcfee added enhancement Does this improve existing functionality? API change Does this change the behavior of existing API? labels Jun 9, 2016
@bmcfee bmcfee added this to the 0.5 milestone Jun 9, 2016
@bmcfee bmcfee self-assigned this Jun 9, 2016
@bmcfee
Copy link
Member Author

bmcfee commented Jun 9, 2016

Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bmcfee bmcfee merged commit fdd4ec6 into master Jun 9, 2016
@bmcfee bmcfee deleted the small_float_finfo branch June 9, 2016 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bmcfee bmcfee

Labels
API change Does this change the behavior of existing API? enhancement Does this improve existing functionality?
Milestone
0.5
Development

Successfully merging this pull request may close these issues.

Replace SMALL_FLOAT with numpy finfo calls
1 participant
@bmcfee