Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All the windows in CQT #414

Merged
merged 3 commits into from Oct 4, 2016
Merged

All the windows in CQT #414

merged 3 commits into from Oct 4, 2016

Conversation

bmcfee
Copy link
Member

@bmcfee bmcfee commented Oct 3, 2016

This PR implements #399:

  • switched -3dB cutoff to equivalent noise bandwidth
  • added window option to all cqt functions
  • modified __float_window to call get_window instead
  • removed default option from window_bandwidth; bad windows should fail noisily.

TODO

  • tests

This change is Reviewable

@bmcfee bmcfee added enhancement Does this improve existing functionality? functionality Does this add new functionality? API change Does this change the behavior of existing API? Hacktoberfest labels Oct 3, 2016
@bmcfee bmcfee added this to the 0.5 milestone Oct 3, 2016
@bmcfee bmcfee self-assigned this Oct 3, 2016
@bmcfee
Copy link
Member Author

bmcfee commented Oct 3, 2016

Note: this PR also introduces a minor backwards incompatibility because it now forces asymmetric windows (through get_window introduced in #413), where the previous version would use symmetric windows everywhere.

I don't expect this to matter in practice, but we should note it in the changelog.

@bmcfee
Copy link
Member Author

bmcfee commented Oct 3, 2016

I think this one's ready for CR -- @dpwe @lostanlen @ebattenberg @ejhumphrey anyone want to claim it?

@ejhumphrey
Copy link

:lgtm:


Reviewed 1 of 2 files at r1, 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@bmcfee bmcfee merged commit b0e7669 into master Oct 4, 2016
@bmcfee bmcfee deleted the window-bandwidth branch October 4, 2016 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API change Does this change the behavior of existing API? enhancement Does this improve existing functionality? functionality Does this add new functionality?
Development

Successfully merging this pull request may close these issues.

None yet

2 participants