Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to audio validation #616

Merged
merged 3 commits into from
Aug 19, 2017
Merged

Improvements to audio validation #616

merged 3 commits into from
Aug 19, 2017

Conversation

bmcfee
Copy link
Member

@bmcfee bmcfee commented Aug 18, 2017 •
edited
Loading

Reference Issue

Example: Fixes #612

What does this implement/fix? Explain your changes.

Added the following checks:

  • subdtype of float
  • ndim is 1 or 2
  • shape[0] <= shape[1]

This change is Reviewable

@bmcfee bmcfee added the enhancement Does this improve existing functionality? label Aug 18, 2017
@bmcfee bmcfee added this to the 0.6.0 milestone Aug 18, 2017
@bmcfee bmcfee self-assigned this Aug 18, 2017
@bmcfee
Copy link
Member Author

bmcfee commented Aug 18, 2017

Reviewed 1 of 2 files at r1.
Review status: 1 of 2 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bmcfee
Copy link
Member Author

bmcfee commented Aug 18, 2017

Reviewed 2 of 3 files at r2.
Review status: 2 of 3 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bmcfee
Copy link
Member Author

bmcfee commented Aug 18, 2017

I removed the proposed transposition check because it fails on duration=0 examples that are otherwise well-formed (ie, have shape=(2,0)).

@bmcfee
Copy link
Member Author

bmcfee commented Aug 19, 2017

Reviewed 1 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bmcfee bmcfee merged commit 079821d into master Aug 19, 2017
@bmcfee bmcfee deleted the valid-audio-improve branch August 19, 2017 01:53
@r9y9 r9y9 mentioned this pull request Oct 26, 2017
Closed
@lostanlen lostanlen mentioned this pull request Aug 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bmcfee bmcfee

Labels
enhancement Does this improve existing functionality?
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

Improve util.valid_audio()
1 participant
@bmcfee