'GetVersionExA': was declared deprecated

[SDLBugzilla]

This bug report was migrated from our old Bugzilla tracker.

Reported in version: 2.0.7
Reported for operating system, platform: Windows 10, x86_64

Comments on the original bug report:

On 2018-01-08 00:53:55 +0000, Steve Robinson wrote:

I run into the following build warning on Windows using the CMake build to generate VS2017 project:
SDL2-2.0.7\src\video\windows\SDL_windowskeyboard.c(457): warning C4996: 'GetVersionExA': was declared deprecated

Looks like it has been replaced with these:
https://msdn.microsoft.com/en-us/library/windows/desktop/dn424972%28v=vs.140%29.aspx
It states the compatibility of each function on its individual API page. Most are all the way down to Windows 2000.

I'm trying to get as much of my codebase to treat warnings as errors so it's easy to see new issues that arise when upgrading libs, upgrading compilers, or changing my code.

By the way, I'm new to Mercurial, I've cloned the repo, but I see no way to submit changes to be considered for inclusion in the product. Is this possible?

Thanks.

-Steve

On 2018-01-08 05:41:33 +0000, Ryan C. Gordon wrote:

We just fixed this issue a few days ago. :)

(For submitting patches, you can make the changes in your local clone and run "hg diff" and attach its output to a bug report. But often times, just letting us know there's a problem is still super-helpful if you don't want to make a fix yourself. So, really, you already did the right thing here.)

--ryan.

*** This bug has been marked as a duplicate of bug 4019 ***

On 2018-01-09 03:47:18 +0000, Steve Robinson wrote:

Super, glad to hear it. Next time, I'll grab the latest from the repo to check the issue before submitting.

Ah, a diff is a nice idea, noted for next time. Thanks all the work on SDL!

-steve