Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EGL: Request sRGB framebuffer in correct place. #2798

Closed
SDLBugzilla opened this issue Feb 11, 2021 · 0 comments
Closed

EGL: Request sRGB framebuffer in correct place. #2798

SDLBugzilla opened this issue Feb 11, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: HG 2.1
Reported for operating system, platform: Linux, All

Comments on the original bug report:

On 2018-01-16 20:41:22 +0000, Deve wrote:

Created attachment 3142
Request sRGB framebuffer in correct place

SDL2 asks for sRGB framebuffer in wrong place when using EGL.

The EGL_GL_COLORSPACE_KHR is an attribute for eglCreate*Surface.

As written in EGL_KHR_gl_colorspace documentation:

Accepted as an attribute name by eglCreateWindowSurface,
eglCreatePbufferSurface and eglCreatePixmapSurface

    EGL_GL_COLORSPACE_KHR                   0x309D

Accepted as attribute values for EGL_GL_COLORSPACE_KHR by
eglCreateWindowSurface, eglCreatePbufferSurface and
eglCreatePixmapSurface

    EGL_GL_COLORSPACE_SRGB_KHR              0x3089
    EGL_GL_COLORSPACE_LINEAR_KHR            0x308A

I'm sending a patch that solves the issue.

On 2018-01-17 21:10:09 +0000, Sam Lantinga wrote:

Added, thanks!
https://hg.libsdl.org/SDL/rev/a01af1a724b3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant