Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11 - XUnmapWindow should not be called directly #607

Closed
SDLBugzilla opened this issue Feb 10, 2021 · 0 comments
Closed

X11 - XUnmapWindow should not be called directly #607

SDLBugzilla opened this issue Feb 10, 2021 · 0 comments

Comments

@SDLBugzilla
Copy link
Collaborator

@SDLBugzilla SDLBugzilla commented Feb 10, 2021

This bug report was migrated from our old Bugzilla tracker.

These attachments are available in the static archive:

Reported in version: HG 2.0
Reported for operating system, platform: Linux, x86

Comments on the original bug report:

On 2012-06-22 15:43:01 +0000, driedfruit wrote:

Created attachment 886
Patch to fix the issue (replace XUnmapWindow with XWithdrawWindow call)

In X11_HideWindow, we call XUnmapWindow to unmap. According to ICCCN2.0, this should never happen, and XWithdrawWindow should be called instead.

http://www.tronche.com/gui/x/icccm/sec-4.html#s-4.1.4

"The reason for requiring the client to send a synthetic UnmapNotify event is to ensure that the window manager gets some notification of the client's desire to change state, even though the window may already be unmapped when the desire is expressed."

Additionally, this can be observed at http://cgit.freedesktop.org/xorg/lib/libX11/tree/src/Withdraw.c#n65

Failure to comply leads to "MapNotify" event never appearing on non-reparenting WMs after subsequent show-hide-show requests. (I'm currently observing this behavior, thus my bug report).

On 2013-07-12 18:52:40 +0000, Ryan C. Gordon wrote:

(Sorry if you get a lot of copies of this email, we're touching dozens of bug reports right now.)

Tagging a bunch of bugs as target-2.0.0, Priority 1.

This means we're in the final stretch for an official SDL 2.0.0 release! These are the bugs we really want to fix before shipping if humanly possible.

That being said, we don't promise to fix them because of this tag, we just want to make sure we don't forget to deal with them before we bless a final 2.0.0 release, and generally be organized about what we're aiming to ship.

Hopefully you'll hear more about this bug soon. If you have more information (including "this got fixed at some point, nevermind"), we would love to have you come add more information to the bug report when you have a moment.

Thanks!
--ryan.

On 2013-07-13 09:14:03 +0000, driedfruit wrote:

Created attachment 1228
minimal test case

Expected behavior: program flickers a window and quits.

Observed behavior: program freezes forever.

On 2013-07-13 09:16:13 +0000, driedfruit wrote:

Created attachment 1229
Patch to fix the issue (replace XUnmapWindow with XWithdrawWindow call)

Updated patch for the latest hg tip.

On 2013-07-13 09:17:04 +0000, driedfruit wrote:

Note: this issue is still relevant.

On 2013-07-14 23:25:57 +0000, miscab wrote:

(In reply to comment # 4)

Note: this issue is still relevant.

your solution is great, does work but something new raised, Please see Bug 1974.

Thank you so much!

Joy

On 2013-07-27 03:50:04 +0000, Sam Lantinga wrote:

Fixed, thanks!
http://hg.libsdl.org/SDL/rev/b186724247dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant