Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL API renaming: SDL_audio.h #6879

Closed
slouken opened this issue Dec 23, 2022 · 1 comment
Closed

SDL API renaming: SDL_audio.h #6879

slouken opened this issue Dec 23, 2022 · 1 comment

Comments

@slouken
Copy link
Collaborator

slouken commented Dec 23, 2022

Here are proposed name changes for functions in SDL_audio.h, per discussion in #6569

SDL_AudioInit => SDL_InitAudio
SDL_AudioQuit => SDL_QuitAudio
SDL_AudioStreamAvailable => SDL_GetAudioStreamAvailable
SDL_AudioStreamClear => SDL_ClearAudioStream
SDL_AudioStreamFlush => SDL_FlushAudioStream
SDL_AudioStreamGet => SDL_GetAudioStreamData
SDL_AudioStreamPut => SDL_PutAudioStreamData
SDL_BuildAudioCVT
SDL_ClearQueuedAudio
SDL_CloseAudio
SDL_CloseAudioDevice
SDL_ConvertAudio
SDL_DequeueAudio
SDL_FreeAudioStream => SDL_DestroyAudioStream
SDL_FreeWAV
SDL_GetAudioDeviceName
SDL_GetAudioDeviceSpec
SDL_GetAudioDeviceStatus
SDL_GetAudioDriver
SDL_GetAudioStatus
SDL_GetCurrentAudioDriver
SDL_GetDefaultAudioInfo
SDL_GetNumAudioDevices
SDL_GetNumAudioDrivers
SDL_GetQueuedAudioSize
SDL_LoadWAV_RW
SDL_LockAudio
SDL_LockAudioDevice
SDL_MixAudio
SDL_MixAudioFormat
SDL_NewAudioStream => SDL_CreateAudioStream
SDL_OpenAudio
SDL_OpenAudioDevice
SDL_PauseAudio
SDL_PauseAudioDevice
SDL_QueueAudio
SDL_UnlockAudio
SDL_UnlockAudioDevice

@libsdl-org/a-team for discussion?

@icculus
Copy link
Collaborator

icculus commented Dec 27, 2022

So reading through these makes me realize there are several changes I want to make that have nothing to do with naming (SDL_FreeWAV should be removed, it's just a wrapper over SDL_free(), etc), and I'll open separate issues for those.

Beyond that, audio changes look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants