Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two testffmpeg requests with fixes included: Add final Vulkan AV1 ext and VVC support.. #9464

Closed
oscarbg opened this issue Apr 6, 2024 · 4 comments

Comments

@oscarbg
Copy link

oscarbg commented Apr 6, 2024

Hi,
both supported in FFMPEG 7.0..

first one replacing in testffmpeg_vulkan:

   "VK_MESA_video_decode_av1"

with:

   VK_KHR_VIDEO_DECODE_AV1_EXTENSION_NAME

present in latest Vulkan SDK..

second one adding :

    if (codecpar->codec_id == AV_CODEC_ID_VVC)
        context->strict_std_compliance = -2;

just before:

result = avcodec_open2(context, codec, NULL);

thanks..

@oscarbg oscarbg changed the title Two requests with fixes included: Add final Vulkan AV1 ext and VVC support.. Two testffmpeg requests with fixes included: Add final Vulkan AV1 ext and VVC support.. Apr 6, 2024
@oscarbg
Copy link
Author

oscarbg commented Apr 11, 2024

I added threaded decode to vvc as it's slow:

if (codecpar->codec_id == AV_CODEC_ID_VVC)
{
    context->strict_std_compliance = -2;

    //#include <thread>
    //const auto processor_count = std::thread::hardware_concurrency();

    //context->thread_count = 16;

    #ifdef _WIN32
    SYSTEM_INFO sysinfo;
    GetSystemInfo(&sysinfo);
    int numCPU = sysinfo.dwNumberOfProcessors;
    context->thread_count = numCPU;
    #else
    context->thread_count =sysconf(_SC_NPROCESSORS_ONLN);
    #endif
    printf("using %d threads for VVC decode\n",context->thread_count);
    context->thread_type = FF_THREAD_FRAME |FF_THREAD_SLICE;
}

@slouken
Copy link
Collaborator

slouken commented Apr 15, 2024

Here you go!

@oscarbg
Copy link
Author

oscarbg commented Apr 16, 2024

Thanks!

@slouken
Copy link
Collaborator

slouken commented Apr 16, 2024

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants