Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

links in preview are broken #54

Closed
funchucks opened this issue Apr 17, 2023 · 0 comments
Closed

links in preview are broken #54

funchucks opened this issue Apr 17, 2023 · 0 comments
Assignees
@icculus

Comments

@funchucks
Copy link

Preview changes absolute links to links relative to the current page, making it appear as if the contributing page editor has made a mistake, broken the page, and should not submit the edit.

For example, currently when you begin to edit:
https://wiki.libsdl.org/SDL2/CategoryInit
...and preview it without making changes, [SDL_Init] makes a link to...
https://wiki.libsdl.org/SDL2/CategoryInit/SDL_Init
...rather than...
https://wiki.libsdl.org/SDL2/SDL_Init
...as it appears before editing.
@icculus icculus transferred this issue from libsdl-org/sdlwiki Apr 18, 2023
@icculus icculus self-assigned this Apr 18, 2023
icculus added a commit that referenced this issue May 10, 2024
@icculus
edit: Fixup links in initial preview data, before any editing.
f1be702 
Fixes #54.
icculus added a commit that referenced this issue May 14, 2024
@icculus
make_new_page_version: output preview HTML with correct relative links.
c3a288e 
Fixes #54.

(Hopefully completely this time!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icculus icculus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icculus @funchucks