SDL_config.h: Assume that all platforms have ISO C89 stddef.h #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdl12-compat's SDL_stdinc.h includes `<stddef.h>` if `HAVE_STDDEF_H` is defined, but until now there was nothing that would have defined that macro. In classic SDL 1.2, SDL_stdinc.h historically included this, and some games (such as Debian package 'berusky') rely on it. stddef.h is required by ISO C89, and is unconditionally included in the headers of some widely portable libraries like libdbus, so it seems safe to assume that all platforms have it (including Windows) unless we hear otherwise. Resolves: libsdl-org#297 Signed-off-by: Simon McVittie <smcv@debian.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sdl12-compat's SDL_stdinc.h includes
<stddef.h>ifHAVE_STDDEF_His defined, but until now there was nothing that would have defined that macro. In classic SDL 1.2, SDL_stdinc.h historically included this, and some games (such as Debian package 'berusky') rely on it.stddef.h is required by ISO C89, and is unconditionally included in the headers of some widely portable libraries like libdbus, so it seems safe to assume that all platforms have it (including Windows) unless we hear otherwise.
Resolves: #297