Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request to tweak book urls in wiki #13

Closed
erikyuzwa opened this issue Feb 20, 2021 · 5 comments
Closed

request to tweak book urls in wiki #13

erikyuzwa opened this issue Feb 20, 2021 · 5 comments
Assignees
@icculus

Comments

@erikyuzwa
Copy link

https://github.com/libsdl-org/SDL/wiki/Books

  • Would appreciate editing the title for Learn C++ By Making Games book to hide the target="blank"

  • Would appreciate editing the title for Game Programming in C++: Start to Finish to also hide the target="blank"

  • For clarity / helpfulness to anyone seeing these entries, can they be tagged somehow as SDL 1.2 material?
@icculus icculus self-assigned this Feb 20, 2021
@slouken
Copy link
Contributor

slouken commented Feb 22, 2021

We're iterating on how we do wiki editing right now, but once we finalize that, we'll make these changes.

Thanks!

@erikyuzwa
Copy link
Author

not a problem at all thanks.

@icculus
Copy link
Contributor

icculus commented Apr 1, 2021

Moving this to sdlwiki for consideration.

@icculus icculus transferred this issue from libsdl-org/SDL Apr 1, 2021
@joshnatis joshnatis mentioned this issue May 12, 2021
Merged
icculus pushed a commit that referenced this issue May 12, 2021
@joshnatis @icculus
Remove target="blank" from titles + small fixes
9ebc41c 
As per [Erik Yuzwa's request](#13 (comment)), I removed target="blank" from the titles of his books and added the clarification that they are on SDL 1.2 material.
@icculus
Copy link
Contributor

icculus commented May 12, 2021

This is resolved now.

@icculus icculus closed this as completed May 12, 2021
@erikyuzwa
Copy link
Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@icculus icculus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@icculus @erikyuzwa @slouken