Skip to content

Commit

Permalink
agent: win32 openssh: Disable overlapped IO
Browse files Browse the repository at this point in the history
Non-blocking IO is not currently supported by the surrounding agent
code, despite a lot of the code having everything set up to handle it.
  • Loading branch information
yodaldevoid committed May 5, 2021
1 parent 2dddcc1 commit 83203df
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion src/agent_win.c
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,15 @@ agent_connect_openssh(LIBSSH2_AGENT *agent)
0,
NULL,
OPEN_EXISTING,
FILE_FLAG_OVERLAPPED |
/* Non-blocking mode for agent connections is not implemented at
* the point this was implemented. The code for Win32 OpenSSH
* should support non-blocking IO, but the code calling it doesn't
* support it as of yet.
* When non-blocking IO is implemented for the surrounding code,
* uncomment the following line to enable support within the Win32
* OpenSSH code.
*/
/* FILE_FLAG_OVERLAPPED | */
SECURITY_SQOS_PRESENT |
SECURITY_IDENTIFICATION,
NULL
Expand Down

0 comments on commit 83203df

Please sign in to comment.