Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLUGIN_BUG(2): _parse_hpssacli_output(): Found duplicate line HPE E208i-a SR Gen10 #337

Closed
mobidyc opened this issue Jul 20, 2018 · 9 comments

Comments

@mobidyc
Copy link

mobidyc commented Jul 20, 2018

Seems to be related to indentation on new Gen10 servers

Python 2.7.5 (default, Aug  4 2017, 00:39:18) 
[GCC 4.8.5 20150623 (Red Hat 4.8.5-16)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import lsm
>>> lsm_client = lsm.Client("hpsa://")
>>> print lsm_client.volumes()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python2.7/site-packages/lsm/_common.py", line 576, in inner
    r = func(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/lsm/_client.py", line 405, in volumes
    return self._tp.rpc('volumes', _del_self(locals()))
  File "/usr/lib/python2.7/site-packages/lsm/_transport.py", line 154, in rpc
    (reply, msg_id) = self.read_resp()
  File "/usr/lib/python2.7/site-packages/lsm/_transport.py", line 181, in read_resp
    raise LsmError(**e)
lsm._common.LsmError: PLUGIN_BUG(2): _parse_hpssacli_output(): Found duplicate line HPE E208i-a SR Gen10 in Slot 0 (Embedded) 
>>> 

below the output of ssacli:


HPE E208i-a SR Gen10 in Slot 0 (Embedded)

APPLICATION UPGRADE REQUIRED: This controller has been configured with a more
                              recent version of software.
                              To prevent data loss, configuration changes to
                              this controller are not allowed.
                              Please upgrade to the latest version to be able
                              to continue to configure this controller.



HPE Smart Array P408i-p SR Gen10 in Slot 2  (sn: PFJHD0ARC950CN)

@mobidyc
Copy link
Author

mobidyc commented Jul 20, 2018

I think the exact command run by hpsa is:

# ssacli ctrl all show detail

HPE E208i-a SR Gen10 in Slot 0 (Embedded)

APPLICATION UPGRADE REQUIRED: This controller has been configured with a more
                              recent version of software.
                              To prevent data loss, configuration changes to
                              this controller are not allowed.
                              Please upgrade to the latest version to be able
                              to continue to configure this controller.



HPE Smart Array P408i-p SR Gen10 in Slot 2
   Bus Interface: PCI
   Slot: 2
   Serial Number: PFJHD0ARC950CN
   RAID 6 (ADG) Status: Enabled
   Controller Status: OK
   Hardware Revision: B
   Firmware Version: 1.34-0
   Rebuild Priority: High
   Expand Priority: Medium
   Surface Scan Delay: 3 secs
   Surface Scan Mode: Idle
   Parallel Surface Scan Supported: Yes
   Current Parallel Surface Scan Count: 1
   Max Parallel Surface Scan Count: 16
   Queue Depth: Automatic
   Monitor and Performance Delay: 60  min
   Elevator Sort: Enabled
   Degraded Performance Optimization: Disabled
   Inconsistency Repair Policy: Disabled
   Write Cache Bypass Threshold Size: 1040 KiB
   Wait for Cache Room: Disabled
   Surface Analysis Inconsistency Notification: Disabled
   Post Prompt Timeout: 15 secs
   Cache Board Present: True
   Cache Status: OK
   Cache Status Details: A cache error was detected. Run a diagnostic report for more information.
   Cache Ratio: 10% Read / 90% Write
   Drive Write Cache: Disabled
   Total Cache Size: 2.0 GB
   Total Cache Memory Available: 1.8 GB
   No-Battery Write Cache: Disabled
   SSD Caching RAID5 WriteBack Enabled: True
   SSD Caching Version: 2
   Cache Backup Power Source: Batteries
   Battery/Capacitor Count: 1
   Battery/Capacitor Status: OK
   SATA NCQ Supported: True
   Spare Activation Mode: Activate on physical drive failure (default)
   Controller Temperature (C): 36
   Cache Module Temperature (C): 30
   Capacitor Temperature  (C): 31
   Number of Ports: 2 Internal only
   Encryption: Disabled
   Express Local Encryption: False
   Driver Name: smartpqi
   Driver Version: 0.9.14-100
   PCI Address (Domain:Bus:Device.Function): 0000:12:00.0
   Negotiated PCIe Data Rate: PCIe 3.0 x8 (7880 MB/s)
   Controller Mode: Mixed
   Port Max Phy Rate Limiting Supported: False
   Latency Scheduler Setting: Disabled
   Current Power Mode: MaxPerformance
   Survival Mode: Enabled
   Host Serial Number: CZ3803FF97
   Sanitize Erase Supported: True
   Sensor ID: 0
      Location: Capacitor
      Current Value (C): 31
      Max Value Since Power On: 38
   Sensor ID: 1
      Location: ASIC
      Current Value (C): 36
      Max Value Since Power On: 44
   Sensor ID: 2
      Location: Unknown
      Current Value (C): 29
      Max Value Since Power On: 37
   Sensor ID: 3
      Location: Cache
      Current Value (C): 30
      Max Value Since Power On: 37
   Primary Boot Volume: None
   Secondary Boot Volume: None

@joehandzik
Copy link
Member

Strange, we definitely have this running across various configurations of Gen10 controllers and haven't seen issues. I'll take a look as time allows and see what I can find.

The message about needing to use a new version of ssacli is a new one to me, and may be worth trying out, just to see if that's causing the variation in output (needs a fix to deal with it either way, but could alleviate your problems in the short-term). Try going out and grabbing the newest version of ssacli (from wherever you're used to getting it from), and see if that helps.

@mobidyc
Copy link
Author

mobidyc commented Jul 24, 2018

I updated ssacli to the version 3.25.
and the problem disappeared.

@cathay4t
Copy link
Contributor

Great. Do we need to support old ssacli also or just close this issue?

@tasleson
Copy link
Member

My preference would be do document the minimum supported version of ssacli and close issue.

@cathay4t
Copy link
Contributor

@joehandzik Which version of ssacli would you suggested to put in the man page of hpsa plugin?

@mobidyc
Copy link
Author

mobidyc commented Jul 25, 2018

I personnaly would prefer that LSM skips an unknown raid card, and continue to the other ones.

In my case ssacli returns an error when I try to access the E208i-a, but as I use only the P408i-p, in command line, there is no issue.

  • I think it will be more difficult to adjust the minimum ssacli version needed each time there is a new controller.

@cathay4t
Copy link
Contributor

cathay4t commented Aug 6, 2018

Silently skip unknown hpsa might waste more time of user when they actually need that card managed by LSM.

I guess suggest user to upgrade their ssacli in PLUGIN_BUG error message might be better.

cathay4t added a commit that referenced this issue Aug 24, 2018
Suggest user to upgrade their ssacli tool when got parsing error.

#337

Signed-off-by: Gris Ge <fge@redhat.com>
@cathay4t
Copy link
Contributor

cathay4t commented Aug 24, 2018

Included suggestion on ssacli tool upgrade when parsing error in commit 00e0048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants