Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CreateOpReturnOutput public #131

Merged
merged 17 commits into from
Dec 6, 2022
Merged

Make CreateOpReturnOutput public #131

Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
aebc0b7
Merge branch 'master' of https://github.com/libsv/go-bt
ordishs Mar 19, 2022
292130b
Fix panic in ToAsm() caused by last commit. (#109)
ordishs Mar 19, 2022
b8fdba0
Fix rename of variable
ordishs Mar 22, 2022
20b08ee
Fixed an old test that was failing due to changes in ToAsm() method
ordishs Mar 22, 2022
ac4c85e
Explicity check error
ordishs Mar 24, 2022
45ff3ee
Merge branch 'master' of github.com:libsv/go-bt
ordishs Sep 28, 2022
67954e0
Spelling
ordishs Nov 10, 2022
b951e0a
All transaction parsing functions now use one function. Added BIP-23…
ordishs Nov 10, 2022
5a13610
Add comments and extra test
ordishs Nov 10, 2022
31354a4
Overcome linter
ordishs Nov 11, 2022
141265f
Linter workarounds
ordishs Nov 11, 2022
00c9231
Linter fix
ordishs Nov 11, 2022
548edc8
More linting workarounds
ordishs Nov 11, 2022
649090f
Minor changes to address comments in PR
ordishs Nov 14, 2022
725ac9c
Merge branch 'master' of github.com:libsv/go-bt
ordishs Dec 6, 2022
d167434
Make CreateOpReturnOutput public
ordishs Dec 6, 2022
9c6e5f0
Added comment to CreateOpReturnOutput
ordishs Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions txoutput.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ func (tx *Tx) AddHashPuzzleOutput(secret, publicKeyHash string, satoshis uint64)
// AddOpReturnOutput creates a new Output with OP_FALSE OP_RETURN and then the data
// passed in encoded as hex.
func (tx *Tx) AddOpReturnOutput(data []byte) error {
o, err := createOpReturnOutput([][]byte{data})
o, err := CreateOpReturnOutput([][]byte{data})
if err != nil {
return err
}
Expand All @@ -170,15 +170,17 @@ func (tx *Tx) AddOpReturnOutput(data []byte) error {
// AddOpReturnPartsOutput creates a new Output with OP_FALSE OP_RETURN and then
// uses OP_PUSHDATA format to encode the multiple byte arrays passed in.
func (tx *Tx) AddOpReturnPartsOutput(data [][]byte) error {
o, err := createOpReturnOutput(data)
o, err := CreateOpReturnOutput(data)
if err != nil {
return err
}
tx.AddOutput(o)
return nil
}

func createOpReturnOutput(data [][]byte) (*Output, error) {
// CreateOpReturnOutput creates a new Output with OP_FALSE OP_RETURN and then
// uses OP_PUSHDATA format to encode the multiple byte arrays passed in.
func CreateOpReturnOutput(data [][]byte) (*Output, error) {
s := &bscript.Script{}

_ = s.AppendOpcodes(bscript.OpFALSE, bscript.OpRETURN)
Expand Down