Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPV validation checks only when requesting ancestry #146

Merged
merged 5 commits into from
Apr 28, 2022

Conversation

sirdeggen
Copy link

Signed-off-by: Darren Kellenschwiler d.kellenschwiler@nchain.com

@sirdeggen sirdeggen added the bug Something isn't working label Apr 22, 2022
@sirdeggen sirdeggen force-pushed the fix/spvEnvelope-to-TxAncestry branch from 31eb3c3 to e6f0ff0 Compare April 25, 2022 11:15
@sirdeggen sirdeggen changed the title WIP: possibly bug which has caused missing merkle proofs SPV validation checks only when requesting ancestry Apr 25, 2022
Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>

only make this if merchant has requested it

Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>

status allow more than one - should just allow any between 200 and 300

Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>

make sure this doesn’t error out in the casae of no ancestry provided.

Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>

revert this

Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>

small detail

Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
@sirdeggen sirdeggen force-pushed the fix/spvEnvelope-to-TxAncestry branch from e42f65c to e0c90f3 Compare April 28, 2022 13:13
theflyingcodr and others added 2 commits April 28, 2022 14:40
Signed-off-by: Darren Kellenschwiler <d.kellenschwiler@nchain.com>
Copy link
Contributor

@theflyingcodr theflyingcodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit f58b5bb into master Apr 28, 2022
@mergify mergify bot deleted the fix/spvEnvelope-to-TxAncestry branch April 28, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants