-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot build 1.18.0 with uClibc #313
Comments
Your CFLAGS:
Does the build fail if you remove |
sounds like a pretty bad idea to define standard C types in your own headers. quick guess, it is the result of ifdef hacks (or making ifdef hacks work) because you lack proper configure-style tests to check for properties of a certain implementation. |
It seems the issue could be solved on Buildroot side, see https://patchwork.ozlabs.org/patch/826925/ I'll close this issue when it disappears on http://autobuild.buildroot.org |
uhm, not sure though what triggered this error, but the (now) failing part is already since 1.16 in ltc...
very true
A side-note to this recurring topic: TBH a lot of my use-cases of ltc included platforms where no configure-style toolchain is easily available (AFAIK) and it always worked OOTB - that was and still is one of the strengths of all the libtom projects in my opinion. |
The trouble here is that |
GCC defines wchar_t even when wchar support is disabled in uClibc. The LTC_NO_WCHAR macro triggers a local definition of wchar_t that conflicts with the GCC defined one. Remove LTC_NO_WCHAR to avoid that. See also libtom/libtomcrypt#313 for more discussion about this. Fixes: http://autobuild.buildroot.net/results/4ff/4ffb593185f7520d2d9a9cc988aa9c510f253930/ Cc: Francois Perrad <francois.perrad@gadz.org> Signed-off-by: Baruch Siach <baruch@tkos.co.il> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Can we close this? |
well http://autobuild.buildroot.org/?reason=libtomcrypt-1.18.0 still shows failing builds |
All those failures use |
On Buildroot, a fix was authored on 2017-10-17, and commited on 2017-10-22. |
On Buildroot, we detect build failures when using uClibc-ng, see http://autobuild.buildroot.org/?reason=libtomcrypt-1.18.0.
The build.log shows a conflict with
wchar_t
This piece of code https://github.com/libtom/libtomcrypt/blob/develop/src/headers/tomcrypt_pk.h#L669-L680 is not suitable with uClibc.
The text was updated successfully, but these errors were encountered: