Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wycheproof failing ECC tests #446

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

karel-m
Copy link
Member

@karel-m karel-m commented Oct 7, 2018

Let's have a valid signature like:

  0x30,0x45,0x02,0x20,0x2b,0xa3,0xa8,0xbe,0x6b,0x94,0xd5,0xec,0x80,0xa6,0xd9,0xd1,0x19,0x0a,
  0x43,0x6e,0xff,0xe5,0x0d,0x85,0xa1,0xee,0xe8,0x59,0xb8,0xcc,0x6a,0xf9,0xbd,0x5c,0x2e,0x18,
  0x02,0x21,0x00,0xb3,0x29,0xf4,0x79,0xa2,0xbb,0xd0,0xa5,0xc3,0x84,0xee,0x14,0x93,0xb1,0xf5,
  0x18,0x6a,0x87,0x13,0x9c,0xac,0x5d,0xf4,0x08,0x7c,0x13,0x4b,0x49,0x15,0x68,0x47,0xdb,

Now let's patch the first 0x30 to 0x31 like:

  0x31,0x45,0x02,0x20,0x2b,0xa3,0xa8,0xbe,0x6b,0x94,0xd5,0xec,0x80,0xa6,0xd9,0xd1,0x19,0x0a,
  0x43,0x6e,0xff,0xe5,0x0d,0x85,0xa1,0xee,0xe8,0x59,0xb8,0xcc,0x6a,0xf9,0xbd,0x5c,0x2e,0x18,
  0x02,0x21,0x00,0xb3,0x29,0xf4,0x79,0xa2,0xbb,0xd0,0xa5,0xc3,0x84,0xee,0x14,0x93,0xb1,0xf5,
  0x18,0x6a,0x87,0x13,0x9c,0xac,0x5d,0xf4,0x08,0x7c,0x13,0x4b,0x49,0x15,0x68,0x47,0xdb,

We still verify the patched signature whereas wycheproof says that the patched signature should be considered invalid.

This PR contains just a failing test not the fix.

@karel-m karel-m changed the title Failing wycheproof test - changing tag value of sequence Failing wycheproof tests Oct 7, 2018
@karel-m
Copy link
Member Author

karel-m commented Oct 7, 2018

I have added one more wycheproof failing test labeled "Edge case for Shamir multiplication" - in this case we reject a signature that is valid (which is less dangerous).

@karel-m
Copy link
Member Author

karel-m commented Oct 7, 2018

Added to more cases (both ASN.1 length encoding) when we accept signature that wycheproof guys consider invalid.

@karel-m karel-m force-pushed the pr/wycheproof-fail-changed-seq-tag branch from 0b85b86 to 5b7d22f Compare October 13, 2018 16:55
@karel-m karel-m changed the title Failing wycheproof tests Wycheproof failing ECC tests Oct 14, 2018
@karel-m karel-m force-pushed the pr/wycheproof-fail-changed-seq-tag branch from d9c0bc4 to 74da361 Compare November 7, 2018 08:13
@sjaeckel sjaeckel force-pushed the pr/wycheproof-fail-changed-seq-tag branch from 74da361 to fe85bcd Compare June 3, 2019 07:28
@sjaeckel sjaeckel added this to the next milestone Oct 26, 2020
@karel-m karel-m force-pushed the pr/wycheproof-fail-changed-seq-tag branch from fe85bcd to e8c61cc Compare April 11, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants