Makefile: Fix shared library build in MinGW. #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables -no-undefined linker flag in mingw toolchain. Previous related commit 9c2c9f8
sjaeckel
approved these changes
Apr 8, 2021
karel-m
approved these changes
Apr 9, 2021
There was a problem hiding this comment.
Looks good
@sjaeckel after merge please add the following comment after line PLATFORM := ...
### Observed uname outputs:
# MINGW32_NT-6.2 (on MSYS/MINGW old)
# MINGW64_NT-10.0-14393 (on MSYS new)
# MSYS_NT-10.0-19042 (on MSYS2)
# CYGWIN_NT-10.0 (on Cygwin 64bit)
# CYGWIN_NT-6.2-WOW64 (on Cygwin 32bit)
# Linux (on all Linux distros)
# Darwin (on macOS, OS X)
|
Ignore my comment. I already see it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables -no-undefined linker flag in mingw toolchain.
Previous related commit 9c2c9f8