Simplify AES-NI detection logic #641
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the patch provided by @thesamesam via [0], but slighly modified. [0] DCIT/perl-CryptX#99 Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
sjaeckel
force-pushed
the
fix-perl-cryptx-99
branch
from
8f5472c
to
d12a272
Compare
|
Let me have a go. Thanks! I don't remember if I managed to reproduce the original problem or if I was just able to reason it out, let's see ;) @hannob Could you try it out on your machine which hit the original Gentoo bug too? |
|
FWIW as @thesamesam asked me to try to reproduce: I can confirm that with this patch I can build libtomcrypt. I can also build CryptX (patch needs a small adaption). But I should also point out that I was unable to reproduce the error I got with CryptX in plain libtomcrypt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the patch provided by @thesamesam via [0], but slighly modified.
@thesamesam could you maybe test whether this patch is fine as well?
[0] DCIT/perl-CryptX#99