Revert "Improve unw_step fallback method on Aarch64." #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d7ca80c. This change makes the assumption that any function with no eh_frame entry has a (ABI-standard) function prolog and no local variables... which means any time that assumption is violated it's just reading random values from the stack and interpreting them as a return address. It's not that unusual to violate those assumptions, and it's better to fail unwinding than to jump to arbitrary memory address found on the stack.
bregma
force-pushed
the
gh-646/master
branch
from
fe7f9d5
to
38b8dc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d7ca80c.
This change makes the assumption that any function with no eh_frame entry has a (ABI-standard) function prolog and no local variables... which means any time that assumption is violated it's just reading random values from the stack and interpreting them as a return address.
It's not that unusual to violate those assumptions, and it's better to fail unwinding than to jump to arbitrary memory address found on the stack.
Fixes #646