Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Improve unw_step fallback method on Aarch64." #659

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert "Improve unw_step fallback method on Aarch64." #659

wants to merge 1 commit into from

Commits on Nov 10, 2023

  1. Revert "Improve unw_step fallback method on Aarch64." 

    This reverts commit d7ca80c.

This change makes the assumption that any function with no eh_frame
entry has a (ABI-standard) function prolog and no local variables...
which means any time that assumption is violated it's just reading
random values from the stack and interpreting them as a return address.

It's not that unusual to violate those assumptions, and it's better to
fail unwinding than to jump to arbitrary memory address found on the
stack.
    @bregma
    bregma committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    38b8dc2 View commit details
    Browse the repository at this point in the history