-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo mantisa -> mantissa #1499
Conversation
This is a change in the API but these structure were merged recently and have not been published in a stable release. I think it is fine to fix the typo. |
@mcuee and @tormodvolden please take a look |
I agree with you. But I will let @tormodvolden decide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This hasn't been released yet and just recently added. Better to fix now, while it doesn't impact too many users (if any).
Yes, there is no problem fixing up the API before it has been published. Thanks for taking a double look! We did a less than stellar job at reviewing this. The spelling was not even consistent with the code comments. Curiously, codespell wouldn't have caught "mantisa" even in a comment. It does find these though, introduced in the same commit:
Further, maybe we should spell superspeed+/SuperSpeed+/SuperSpeedPlus consistently, also for better searchability? Apart from certain platform files in os/* we use classic style /* */ for comments and not the C++ style // up to now almost consistently, so it we shouldn't diverge here. Can you please fix up these as well? In the meantime I'll merge the present API change, it is worth having it separately from cosmetic changes in any case. |
@tormodvolden: All done in PR #1502 1502 |
The correct spelling is "mantisSa"