Fix builds on Solaris/AIX using native compilers. #1259
Conversation
The current `configure.ac` has a TODO to detect `-pthread` vs `-pthreads` and the forced use of `-pthreads` in `Makefile.am` breaks the build on Solaris when using Oracle Studio instead of GCC. The open-source `ax_pthread.m4` macro exists to detect the appropriate `libpthread` flags, libraries, and compiler (in the case of AIX when not using GCC) to use.
The auto-detection of GCC specific options does not work when building with Oracle Studio, as that compiler interprets the flags differently without returning a bad return code for `autoconf` to detect.
The `HAVE_SYS_AHAFS_EVPRODS_H` define is properly auto-detected by `autoconf` and must not be forced on for systems that do not have `ahafs` installed. There is no way to auto-detect this in `gyp`, so the flag remains in `uv.gyp`.
There was a problem hiding this comment.
@apaprocki - the enforcement of this flag has a reason, and here is the history:
#1156 (comment)
In short, the community agreed that we enforce installation of AHAFS on AIX systems, as the fs.watch APIs critically depend on it. If the user is not interested in AHAFS related usages, he can always remove the flag manually and built. On the other hand, the pre-built binary will just work fine.
|
@apaprocki - curious to know - in general, what is your motivation behind building with non-gcc compilers? any performance goals? or integration of libuv with some legacy systems? or some new use case? |
|
@gireeshpunathil I implemented AHAFS detection in #372 and it worked perfectly fine until #1156 broke the code. I agree you need to force it on in the We use the native compilers on Solaris and AIX because we link |
|
@apaprocki - can you elaborate on Are you proposing that the AHAFS feature should be opted out through autoconf via auto-detection, if the package is missing, and retain the behavior when built via gyp? |
|
On the use case part, thanks for the explanation. I thought that the GCC-built images can link and co-exist with natively built libraries. That isn't the case? |
|
This is adding GPL code into a MIT licensed project, I don't think that is workable. |
|
@sam-github Ah, I mis-read the special exemption text. It only applies to the output of |
|
@gireeshpunathil After #1156, |
|
@apaprocki : yes, agree - but then this will have two implications:
I am not arguing the current one is better over the proposal etc., just placing things into perspectives and letting the reviewers know the context better. |
|
It seems like this PR might have run its course. I'm going to close. Please let me know if that is the wrong thing to do. |
These commits fix the build on Solaris using Oracle Studio and the build on AIX using IBM Visual Age compilers. I built these changes on both Solaris/AIX using the native compilers as well as using GCC 6 just to verify that there were no regressions. Each commit log entry has an explanation.