Disable SYS_close syscall when Thread Sanitizer is active #3112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bnoordhuis
approved these changes
Feb 19, 2021
oerdnj
force-pushed
the
v1.x-disable-SYS_close-under-thread-sanitizer
branch
from
c08b5a9
to
82c614e
Compare
|
@bnoordhuis Thanks for the explanation, somehow I missed the comment at the top of the function. Meanwhile, after more chat with LLVM/TSAN developer, I changed the commit to use pre- and post- sanitizer wrappers, which has the same effect, but keeps the |
bnoordhuis
approved these changes
Feb 20, 2021
Thread Sanitizer can't intercept syscall(SYS_close, fd) that's used instead of close(fd); on Linux. That leads to false positives as Thread Sanitizer thinks the descriptor is still being used by the thread. clang defines pre- and post- syscall actions, so wrap the close syscall() into the action macros. For gcc, use close() from glibc instead of the syscall. This allows the thread sanitizer to intercept closing of the file descriptor when libuv is compiled with Thread Sanitizer.
oerdnj
force-pushed
the
v1.x-disable-SYS_close-under-thread-sanitizer
branch
from
82c614e
to
9de7e7f
Compare
bnoordhuis
approved these changes
Feb 22, 2021
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
bump |
santigimeno
pushed a commit
that referenced
this pull request
Apr 4, 2021
Thread Sanitizer can't intercept syscall(SYS_close, fd) that's used instead of close(fd); on Linux. That leads to false positives as Thread Sanitizer thinks the descriptor is still being used by the thread. clang defines pre- and post- syscall actions, so wrap the close syscall() into the action macros. For gcc, use close() from glibc instead of the syscall. This allows the thread sanitizer to intercept closing of the file descriptor when libuv is compiled with Thread Sanitizer. PR-URL: #3112 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
Landed in c3fe3cf. Thanks! |
JeffroMF
pushed a commit
to JeffroMF/libuv
that referenced
this pull request
May 16, 2022
Thread Sanitizer can't intercept syscall(SYS_close, fd) that's used instead of close(fd); on Linux. That leads to false positives as Thread Sanitizer thinks the descriptor is still being used by the thread. clang defines pre- and post- syscall actions, so wrap the close syscall() into the action macros. For gcc, use close() from glibc instead of the syscall. This allows the thread sanitizer to intercept closing of the file descriptor when libuv is compiled with Thread Sanitizer. PR-URL: libuv#3112 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread Sanitizer doesn't intercept syscall(SYS_close, fd) that's used
instead of close(fd); on Linux. That leads to false positives as Thread
Sanitizer thinks the descriptor is still being used by the thread.
Disabling the usage of SYS_close won't help in common case where the
libuv is not instrumented, but at least it gives the developers an
option to prepare a Thread Sanitizer compatible build by compiling an
instrumented version.
Some extra notes:
SYS_close? I understand the need ofsyscalls()for interfaces that might not be in libc, but is that really necessary forclose()?