win: fix unexpected ECONNRESET error on TCP socket #3584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
reviewed
Apr 4, 2022
vtjnash
reviewed
Apr 4, 2022
vtjnash
reviewed
Apr 4, 2022
vtjnash
reviewed
Apr 4, 2022
vtjnash
reviewed
Apr 4, 2022
vtjnash
reviewed
Apr 4, 2022
vtjnash
reviewed
Apr 4, 2022
vtjnash
reviewed
Apr 4, 2022
vtjnash
approved these changes
Apr 4, 2022
vtjnash
reviewed
Apr 4, 2022
Also surprised...
Fixed. It seems that the code style in the existing tests is not unified, I just found one to imitate. IMO, 80 characters seems a bit conservative nowadays. XD |
vtjnash
approved these changes
Apr 4, 2022
|
What can I say haha? libuv is a conservative library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced by #3036.
The order of calling
uv_read_stop()anduv__tcp_try_cancel_reqs()doesn't seem to matter. But callinguv_read_stop()first is more in line with the order in which the user (me) uses these APIs, anduv_read_stop()is more soft I think.Close the tcp handle after
uv_read_start()immediately without a timer can also reproduce the problem, but I still constructed a test that is closer to my example to make sure it doesn't go wrong again.@vtjnash Thank you very much for your pointers, after spending some time reading the related source code, I also learned something, especially since I almost never read the source code under the Windows platform before.
Please correct me if I am doing something wrong :)