Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninitialized variable: mode in function im_vips2dz() #1419

Closed
yifengchen-cc opened this issue Sep 3, 2019 · 2 comments
Closed

Uninitialized variable: mode in function im_vips2dz() #1419

yifengchen-cc opened this issue Sep 3, 2019 · 2 comments

Comments

@yifengchen-cc
Copy link

/libvips/libvips/deprecated/im_vips2dz.c:79
When the output file does not contain a ":",the uninitialization of the mode causes the stack information to leak.
This may cause the leakage of remote server path.
$./vips im_vips2dz /home/ivan/miniproject/libvips/tools/.libs/th.vips th.dz
im_vips2dz: enum 'VipsForeignDzLayout' has no member 'roject/libvips/tools/.libs/th.vips', should be one of: dz, zoomify, google

@jcupitt
Copy link
Member

jcupitt commented Sep 3, 2019

Oh, good point! Thank you for reporting this. I've fixed git master.

The stuff in "deprecated" is not checked by the fuzzer :(

jcupitt added a commit that referenced this issue Sep 3, 2019
we were reading an uninited string in a vips7 compatibility wrapper, thanks
yifengchen-cc

see #1419
@jcupitt jcupitt closed this as completed Sep 15, 2019
@lovell
Copy link
Member

lovell commented Nov 21, 2020

It looks like this has been assigned CVE-2020-20739.

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-20739
https://nvd.nist.gov/vuln/detail/CVE-2020-20739

There's no severity listed, but I imagine usage in the wild of this deprecated code path will be very low.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants