Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to convert many png after update to libvips v8.11.3 #2433

Closed
Lathanderjk opened this issue Sep 13, 2021 · 4 comments
Closed

Unable to convert many png after update to libvips v8.11.3 #2433

Lathanderjk opened this issue Sep 13, 2021 · 4 comments
Labels
bug

Comments

@Lathanderjk
Copy link

Lathanderjk commented Sep 13, 2021 •
edited
Loading

Converting of many png pictures start crashing after update to v8.11.3 with message "vip song: too many text chunks" after downgrade to v8.11.2 everything is back to normal.

Example png:

hp-17a-cf217a-original-laserjet-toner-cartridge-black-216027
jcupitt added a commit that referenced this issue Sep 13, 2021
@jcupitt
raise the PNG text chunk limit
15416c4 
Raise the PNG text chunk limit to 50, since it seems some real images
have a text chunk per line of exif data.

See #2433
@jcupitt
Copy link
Member

jcupitt commented Sep 13, 2021

Hi @Lathanderjk, thanks for the test image.

8.11.3 added a thing to detect PNG images with very large numbers of text chunks. This is a DoS attack pattern, unfortunately.

Your image has 28 text chunks (!!!), it seems to have a text chunk for each line of each metadata type.

I've raised the limit to 50 for 8.11.4, would you be able to test this?

@Lathanderjk
Copy link
Author

Thank you,
Looks enough for all we tested so far.

@jcupitt
Copy link
Member

jcupitt commented Sep 16, 2021

That's great, thank you for checking. We'll push out 8.11.4 in a day or two.

@jcupitt
Copy link
Member

jcupitt commented Sep 30, 2021

OK, it's out, I'll close. Thanks for reporting this.

@jcupitt jcupitt closed this as completed Sep 30, 2021
@fvsnippets fvsnippets mentioned this issue Oct 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcupitt @Lathanderjk