-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect ratio when thumbnail_image
called after autorot
#226
Comments
Sorry forgot to include versions:
|
Hi @malomalo, thanks for the report, I'll have a look. |
Thanks @jcupitt. While your looking at it is there a way to have ruby-vips rescan/reload the image to get the right dimensions? Currently I'm trying to find a way to dump a buffer and reload, but it seems I always need define a file type. |
Ooops, this dropped off my radar, sorry, I'll try to check tomorrow. |
We were writing the wrong image to the output. See libvips/ruby-vips#226
we were writing the wrong image to the output, thanks malomalo see libvips/ruby-vips#226
It seems to be working for me now -- there was a regression in autorot. This fix will be in 8.9.2 (head of 8.9 branch). Thanks for reporting this dumbness! |
On your code snippet, You are using
These are the default settings for (I realize this is just test code and you probably know all this, but I thought I'd say just in case) |
While your looking at it is there a way to have ruby-vips rescan/reload the image to get the right dimensions? Currently I'm trying to find a way to dump a buffer and reload, but it seems I always need define a file type. I'm not sure I understand -- how might it not have the correct dimensions? Is this after the file has been modified? |
Here's a benchmark for
So |
Awesome! Thanks @jcupitt, it's resolved all my issues. I'll take a look at |
OK, glad it's working. 8.9.2 is out now. |
Sorry to bring this up again, I just deployed this into production and still seeing this on some images, |
Hi @malomalo, sorry to hear it's not working. Could you post a sample image and the code that fails, please. |
Sorry, found the issue after some more debugging, it was an issue with what I was passing that gave me the same error. |
thumbnail_image
uses the old dimensions/ratio when called after anautorot
.Here is an example image and test case, I'm not sure on the best path forward to fix this issue.
Anyone else run into this issue?
Output:
The text was updated successfully, but these errors were encountered: