New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRC - May 2017 #52

Merged
merged 2 commits into from May 24, 2017

Conversation

Projects
None yet
2 participants
@manwar
Contributor

manwar commented May 24, 2017

Hi @oalders

Please review the PR done as a part of PRC.
This removes minor warning during build complaining about missing abstract in the package Net::HTTP::Methods.

[DZ] beginning to build Net-HTTP
[@author::OALDERS/PodWeaver] [@Default/Name] couldn't find abstract in lib/Net/HTTP/Methods.pm

Many Thanks.
Best Regards,
Mohammad S Anwar

Show outdated Hide outdated lib/Net/HTTP/Methods.pm
__END__
# ABSTRACT: Represents method for Net::HTTP

This comment has been minimized.

@oalders

oalders May 24, 2017

Member

Maybe we could change this to:

`# ABSTRACT: Methods shared by Net::HTTP and Net::HTTPS

What do you think?

@oalders

oalders May 24, 2017

Member

Maybe we could change this to:

`# ABSTRACT: Methods shared by Net::HTTP and Net::HTTPS

What do you think?

@oalders

This comment has been minimized.

Show comment
Hide comment
@oalders

oalders May 24, 2017

Member

Hi @manwar,

Thanks very much for this! I had one small comment.

All the best,

Olaf

Member

oalders commented May 24, 2017

Hi @manwar,

Thanks very much for this! I had one small comment.

All the best,

Olaf

@manwar

This comment has been minimized.

Show comment
Hide comment
@manwar

manwar May 24, 2017

Contributor

Hi @oalders

Updated the abstract as you suggested.

Best Regards.
Mohammad S Anwar

Contributor

manwar commented May 24, 2017

Hi @oalders

Updated the abstract as you suggested.

Best Regards.
Mohammad S Anwar

@oalders

This comment has been minimized.

Show comment
Hide comment
@oalders

oalders May 24, 2017

Member

@manwar thanks so much!

Member

oalders commented May 24, 2017

@manwar thanks so much!

@oalders oalders merged commit 80d6012 into libwww-perl:master May 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment