PRC - May 2017 #52
Merged
PRC - May 2017 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t in Net::HTTP::Methods.
oalders
reviewed
May 24, 2017
lib/Net/HTTP/Methods.pm
Outdated
|
|
||
| __END__ | ||
|
|
||
| # ABSTRACT: Represents method for Net::HTTP |
There was a problem hiding this comment.
Maybe we could change this to:
`# ABSTRACT: Methods shared by Net::HTTP and Net::HTTPS
What do you think?
|
Hi @manwar, Thanks very much for this! I had one small comment. All the best, Olaf |
|
Hi @oalders Updated the abstract as you suggested. Best Regards. |
|
@manwar thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @oalders
Please review the PR done as a part of PRC.
This removes minor warning during build complaining about missing abstract in the package Net::HTTP::Methods.
[DZ] beginning to build Net-HTTP
[@author::OALDERS/PodWeaver] [@Default/Name] couldn't find abstract in lib/Net/HTTP/Methods.pm
Many Thanks.
Best Regards,
Mohammad S Anwar