Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use HTML::TreeBuilder 5 -weak; #251

Closed
oalders opened this issue Jul 3, 2018 · 0 comments · Fixed by #262
Closed

use HTML::TreeBuilder 5 -weak; #251

oalders opened this issue Jul 3, 2018 · 0 comments · Fixed by #262

Comments

@oalders
Copy link
Member

oalders commented Jul 3, 2018 •
edited
Loading

See https://metacpan.org/pod/HTML::Element#Weak-References

This would mean we could stop calling delete() here https://metacpan.org/source/OALDERS/WWW-Mechanize-1.88/lib/WWW/Mechanize.pm#L325
@oalders oalders changed the title use HTML::TreeBuilder 5 -weak; use HTML::TreeBuilder 5 -weak; Jul 4, 2018
simbabque added a commit to simbabque/WWW-Mechanize that referenced this issue Nov 2, 2018
@simbabque
upgrade to HTML::TreeBuilder 5 to get weak references
f0183ff 
This might break people's code on really old Perls.

Closes libwww-perl#251
@simbabque simbabque mentioned this issue Nov 2, 2018
Merged
oalders pushed a commit that referenced this issue Nov 11, 2018
@simbabque @oalders
upgrade to HTML::TreeBuilder 5 to get weak references
e5ed735 
This might break people's code on really old Perls.

Closes #251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

upgrade to HTML::TreeBuilder 5 to get weak references simbabque/WWW-Mechanize
1 participant
@oalders