-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a looping regression for 303 responses without a Location header #342
Conversation
The change in 6.45 had a side effect of making it look at max_redirect only when the Location header is set. The libapache2-mod-perl2 test suite implements a test server that answers with HTTP code 303 without including such a header. RFC 7231 is not very clear on whether Location is required, although the response doesn't make much sense without it. Some googling reveals this is not a new question. https://stackoverflow.com/questions/16194988/for-which-3xx-http-codes-is-the-location-header-mandatory For the sake of robustness I suppose libwww-perl needs to be fixed. Bug-Debian: https://bugs.debian.org/962904
Not sure if this reintroduces the issue 6.45 was fixing. The t/redirect tests still pass, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ntyni!
@ntyni are you able to have a look at |
7af78df
to
a8ae2b7
Compare
I doubt it regressed with this. It's working for me now. Not sure if it's intentional that only some of the live/jigsaw/ tests are skipped for NO_JIGSAW=1 ? |
One of the issues with these live tests is that they can start to fail if there's some throttling going on. I can see that it's now passing, so we can punt on it for now! :) |
This works around a bug in LWP::UserAgent 6.45. libwww-perl/libwww-perl#342
The change in 6.45 had a side effect of making it look at max_redirect only when the Location header is set.
The libapache2-mod-perl2 test suite implements a test server that answers with HTTP code 303 without including such a header.
RFC 7231 is not very clear on whether Location is required, although
the response doesn't make much sense without it.
Some googling reveals this is not a new question.
https://stackoverflow.com/questions/16194988/for-which-3xx-http-codes-is-the-location-header-mandatory
For the sake of robustness I suppose libwww-perl needs to be fixed.
Bug-Debian: https://bugs.debian.org/962904