Allow IPv6 proxy hosts starting with [. #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altered the regular expression that checked for a sane-ish looking URL for our proxy host: if $url =~ /^https?:/ && $url !~ m,^https?://\w,; Given this expression, a proxy host in the form of http://[::1]:33485/ would fail because it starts with a left bracket. The expression above has been altered to: if $url =~ /^https?:/ && $url !~ m,^https?://[\w[],; Which will allow it to begin with a word character or a left bracket. This will resolve issue #237 Also, edit the Travis config to ensure we test against threaded Perls.
oalders
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altered the regular expression that checked for a sane-ish looking
URL for our proxy host:
if $url =~ /^https?:/ && $url !~ m,^https?://\w,;
Given this expression, a proxy host in the form of
http://[::1]:33485/ would fail because it starts with a left bracket.
The expression above has been altered to:
if $url =~ /^https?:/ && $url !~ m,^https?://[\w[],;
Which will allow it to begin with a word character or a left bracket.
This will resolve issue #237