Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow IPv6 proxy hosts starting with [. #306

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Allow IPv6 proxy hosts starting with [. #306

merged 1 commit into from
Mar 6, 2019

Commits on Mar 6, 2019

  1. Allow IPv6 proxy hosts starting with [.

    Altered the regular expression that checked for a sane-ish looking
    URL for our proxy host:
    
     if $url =~ /^https?:/ && $url !~ m,^https?://\w,;
    
    Given this expression, a proxy host in the form of
    http://[::1]:33485/ would fail because it starts with a left bracket.
    
    The expression above has been altered to:
    
     if $url =~ /^https?:/ && $url !~ m,^https?://[\w[],;
    
    Which will allow it to begin with a word character or a left bracket.
    
    This will resolve issue #237
    
    Also, edit the Travis config to ensure we test against threaded Perls.
    genio committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    9889d18 View commit details
    Browse the repository at this point in the history