Merge pull request #150 from SYSTRAN/clone_segfault

fix segfault for clone
libxmljs · Jul 26, 2012 · 31fa8c4 · 31fa8c4
2 parents 88a633c + 68ec745
commit 31fa8c4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/xml_node.cc b/src/xml_node.cc
@@ -296,7 +296,8 @@ v8::Handle<v8::Value>
 XmlNode::clone(bool recurse) {
   v8::HandleScope scope;
 
-  return scope.Close(XmlNode::New(xmlCopyNode(xml_obj, recurse)));
+  xmlNode* new_xml_obj = xmlDocCopyNode(xml_obj, xml_obj->doc, recurse);
+  return scope.Close(XmlNode::New(new_xml_obj));
 }
 
 v8::Handle<v8::Value>

diff --git a/test/element.js b/test/element.js
@@ -137,3 +137,13 @@ module.exports.import = function(assert) {
     assert.equal(child1, elem.childNodes()[0]); // child1 is the the first child of elem
     assert.done();
 };
+
+module.exports.clone = function(assert) {
+    var doc = libxml.Document();
+    var elem = doc.node('child');
+    var elem2 = elem.clone();
+    assert.equal(elem.name(), elem2.name());
+    assert.equal(elem.text(), elem2.text());
+    assert.equal(elem.toString(), elem2.toString());
+    assert.done();
+};