-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/640 #641
Bugfix/640 #641
Conversation
Added XMLNode|null for prevSibling and nextSibling. All types excepct XMLDocument inherit from XMLNode and XMLDocument can not be returned in this case.
@rchipka The pipeline fails due to a GYP error. I cannot fix this error myself. |
We shouldn't use refToNodeType because then we have to use a type assertion. Instead we should check if the |
Also if you could add a test for this that would be greatly appreciated |
Hmm, although that does raise the question of how to handle casting to XMLElement in nextElement/prevElement |
In principle, In principle, I think that refToNodeType is already correct. However, the document node should probably still be explicitly checked here so that the types are correct. An XML element should always be returned for an element reference. |
It also seems that the build on ubuntu does work fine. Whats reason why it does fail on macos? I am not familiar with GYP errors. |
Seems like maybe a python version issue considering the error is related to unknown flags for an |
I agree that we should always return an instance that best matches the underlying node ref type, however I'm wondering if there's a way we can do this without a manual type assertion |
Fixes #640