Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-pre-gyp #523

Merged
merged 1 commit into from Aug 23, 2018
Merged

Update node-pre-gyp #523

merged 1 commit into from Aug 23, 2018

Conversation

KillWolfVlad
Copy link
Contributor

After upgrade to libxmljs v0.19.1 some users (#511 and #506) have troubles with compilation under Node.js 10.

libxmljs v0.19.1 have one change - bump node-pre-gyp. But in node-pre-gyp v0.10.x was bug, that was fixed in v0.11.0.

This commit should fix any installation problems (works for me). Anyway node-pre-gyp must be upgraded.

P.S. I use renovate to automatically update dependencies (it is free for open source, just try it 😄)

@rchipka
Copy link
Member

rchipka commented Aug 23, 2018

💯

@KillWolfVlad I'll look into it today if I have time

@rchipka rchipka merged commit e6d44d3 into libxmljs:master Aug 23, 2018
@rchipka
Copy link
Member

rchipka commented Aug 23, 2018

v0.19.2 published via NPM

@KillWolfVlad
Copy link
Contributor Author

Thanks! Do not forget tag this release #519

@KillWolfVlad KillWolfVlad deleted the deps/node-pre-gyp branch August 23, 2018 14:41
@kumarrishav
Copy link

Has same issue. Thanks for the fix @KillWolfVlad

@rchipka
Copy link
Member

rchipka commented Aug 23, 2018

@KillWolfVlad Ah, good call

@rchipka
Copy link
Member

rchipka commented Aug 23, 2018

v0.19.3 published via NPM

eyz added a commit to eyz/node-xmlshim that referenced this pull request Aug 27, 2018
eyz added a commit to eyz/node-xmlshim that referenced this pull request Aug 27, 2018
eyz added a commit to eyz/node-xmlshim that referenced this pull request Aug 27, 2018
eyz added a commit to eyz/node-blockly that referenced this pull request Aug 27, 2018
@richtera
Copy link

Is there any news on this. Basically libxmljs forces me to use node v9 instead of v10. I know that's not fatal, but is kind of annoying.

@richtera
Copy link

Starting to be more important: error graphql@14.0.0: The engine "node" is incompatible with this module. Expected version "6.x || 8.x || >= 10.x".

@eyz
Copy link

eyz commented Aug 31, 2018

@richtera I'm having luck with libxmljs 0.19.3 for node-blockly on NodeJS 10.x.

libxmljs 0.19.3 is already published to NPM. What are your dependencies? libxmljs, or another library that is using it?

@richtera
Copy link

richtera commented Sep 1, 2018

Hmmm Not sure how to debug it then. Must be another peer dependency then that's preventing this to install :(

@eyz
Copy link

eyz commented Sep 1, 2018

@richtera see my comment @ znerol/node-xmlshim#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants