Fix double free in case of PCM sample load error

This hard to spot bug was caught in Lionel Debroux's honggfuzz tests. Kudos to him! Signed-off-by: Claudio Matsuoka <cmatsuoka@gmail.com>
libxmp · Nov 20, 2016 · bd1eb5c · bd1eb5c
1 parent 0935751
commit bd1eb5c
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/src/loaders/sample.c b/src/loaders/sample.c
@@ -410,6 +410,7 @@ int libxmp_load_sample(struct module_data *m, HIO_HANDLE *f, int flags, struct x
 #ifndef LIBXMP_CORE_PLAYER
     err2:
 	free(xxs->data - 4);
+	xxs->data = NULL;	/* prevent double free in PCM load error */
 #endif
     err:
 	return -1;