Extended NCApplication::runInTerminal for RSpec #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually RSpec is just an example.
runInTerminal("#open_ncurses") paired with
runInTerminal("#close_ncurses") will do just the respective halves,
allowing non-ncurses code access stdout afterwards.
|
I am moving this functionality into |
Reverting the hack with runInTerminal.
This was referenced Jul 8, 2015
|
LGTM |
mvidner
added a commit
that referenced
this pull request
Jul 8, 2015
Added NCApplication::openUI/closeUI (boo#937026).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for yast/yast-journal#15, boo#937026
Cc: @ancorgs @shundhammer
Yes, it is an abuse of the API. A proper fix means adding a new API to this package and to https://github.com/libyui/libyui and to https://github.com/yast/yast-ycp-ui-bindings so I want to see whether it helps at all before touching more packages.