Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Ruby 2.7 #694

Merged
merged 6 commits into from
Dec 31, 2023
Merged

Remove support for Ruby 2.7 #694

merged 6 commits into from
Dec 31, 2023

Conversation

mlinksva
Copy link
Contributor

EOL since 2023-03-31 https://www.ruby-lang.org/en/downloads/branches/

Various rubocop suggestions for Ruby 3.0+

@mlinksva mlinksva merged commit 24f3794 into main Dec 31, 2023
8 checks passed
@mlinksva mlinksva deleted the rm27 branch December 31, 2023 19:55
@dmoss18
Copy link

dmoss18 commented Feb 23, 2024

Just FYI this is a breaking change and you included it in a patch release. Anybody still on ruby 2.7 who goes from 9.16.0->9.16.1 can no longer bundle install. Should this have been a major release instead of a patch?

@mlinksva
Copy link
Contributor Author

mlinksva commented Feb 25, 2024

bundle install simply not installing 9.16.1 (if your Ruby version doesn't match 9.16.1's requirements) is the reason I considered it OK to make it a patch release based on what is in the release, just a small bugfix and various version updates. Nothing will break, you just don't get the new version. And if you try to manually set the new version, you still won't get it.

If there's a Ruby (or broader) consensus to always make required language version (or say changes in platform support) mandate a major version change, happy to take this onboard for future releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants