better guess if the clock is running

lichess-org · Mar 13, 2024 · 127ba9c · 127ba9c
1 parent 14b297c
commit 127ba9c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/ui/analyse/src/study/multiBoard.ts b/ui/analyse/src/study/multiBoard.ts
@@ -1,5 +1,5 @@
 import * as licon from 'common/licon';
-import { clockIsRunning, formatMs } from 'common/clock';
+import { otbClockIsRunning, formatMs } from 'common/clock';
 import { fenColor } from 'common/miniBoard';
 import { MaybeVNode, VNode, bind, onInsert, looseH as h } from 'common/snabbdom';
 import { opposite as CgOpposite, uciToMove } from 'chessground/util';
@@ -210,7 +210,7 @@ const renderUser = (player: ChapterPreviewPlayer): VNode =>
 export const renderClock = (chapter: ChapterPreview, color: Color) => {
   const turnColor = fenColor(chapter.fen);
   const timeleft = computeTimeLeft(chapter, color);
-  const ticking = turnColor == color && clockIsRunning(chapter.fen, color);
+  const ticking = turnColor == color && otbClockIsRunning(chapter.fen);
   return defined(timeleft)
     ? h(
         'span.mini-game__clock.mini-game__clock',

diff --git a/ui/common/src/clock.ts b/ui/common/src/clock.ts
@@ -6,7 +6,9 @@ export const formatMs = (msTime: number) => {
   return hours > 0 ? hours + ':' + pad(minutes) + ':' + pad(seconds) : minutes + ':' + pad(seconds);
 };
 
-export const clockIsRunning = (fen: string, color: Color) =>
+export const otbClockIsRunning = (fen: string) => !fen.includes('PPPPPPPP/RNBQKBNR');
+
+export const lichessClockIsRunning = (fen: string, color: Color) =>
   color == 'white' ? !fen.includes('PPPPPPPP/RNBQKBNR') : !fen.startsWith('rnbqkbnr/pppppppp');
 
 const pad = (x: number) => (x < 10 ? '0' : '') + x;
diff --git a/ui/site/src/miniGame.ts b/ui/site/src/miniGame.ts
@@ -4,7 +4,7 @@ import { type Chessground } from 'chessground';
 import * as domData from 'common/data';
 import clockWidget from './clockWidget';
 import StrongSocket from './socket';
-import { clockIsRunning } from 'common/clock';
+import { lichessClockIsRunning } from 'common/clock';
 
 export const init = (node: Element, withCg?: typeof Chessground) => {
   const [fen, color, lm] = node.getAttribute('data-state')!.split(','),
@@ -33,7 +33,7 @@ export const init = (node: Element, withCg?: typeof Chessground) => {
     $el.find('.mini-game__clock--' + color).each(function (this: HTMLElement) {
       clockWidget(this, {
         time: parseInt(this.getAttribute('data-time')!),
-        pause: color != turnColor || !clockIsRunning(fen, color),
+        pause: color != turnColor || !lichessClockIsRunning(fen, color),
       });
     }),
   );
@@ -60,7 +60,7 @@ export const update = (node: HTMLElement, data: MiniGameUpdateData) => {
     if (!isNaN(time!))
       clockWidget($el[0]?.querySelector('.mini-game__clock--' + color) as HTMLElement, {
         time: time!,
-        pause: color != turnColor || !clockIsRunning(data.fen, color),
+        pause: color != turnColor || !lichessClockIsRunning(data.fen, color),
       });
   };
   updateClock(data.wc, 'white');