Fix for Rating range not set to max value when switching to a perf with provisional rating (Issue #12801) #12916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling from main
…'t set to -500 and 500 when rating is provisional.
Changed ratingDifference Sliders to show -500 and 500 as default values when isProvisional
Changed such that when a user switches to a variant that doesn't have a provisional rating, then rating slider sets back to stored values.
Changed functioning such that it knows when the variant of the game is changed so that it resets to stored value.
Remove console logs
Lint issues with tabs and spaces.
Removed double negation.
Mixed tabs and spaces
Prettier formatting
Prettier Formatting
Prettier Formatting
…ating as they switch variants
* master: New Crowdin updates (lichess-org#12914) upgrade play use play.mailer fix ApiMoveStream Revert "Metal BG for blog" scala code golf Update uap-scala to 0.15.0 Update sbt to 1.8.3 Update netty-transport-native-epoll to 4.1.93.Final Update google-auth-library-oauth2-http to 1.17.0 Increase Firefox min version for coep:credentialless origin trial to 114 Set first letter of every language to uppercase
ornicar
requested changes
May 30, 2023
ui/lobby/src/setupCtrl.ts
Outdated
| @@ -149,9 +148,45 @@ export default class SetupController { | |||
| aiLevel: this.aiLevel(), | |||
| }); | |||
|
|
|||
| private savePropsToStoreExceptRating = () => { | |||
| if (this.gameType && this.store[this.gameType]) { | |||
There was a problem hiding this comment.
but then it won't save anything if this.store[this.gameType] doesn't yet exist? Which is not how savePropsToStore works. Is that intended?
There was a problem hiding this comment.
Changed it to follow existing saveProps
There was a problem hiding this comment.
I had to make a separate eventListener for variant as whenever we switch to a provisional rating variant, I had to change the ratingMin and ratingMax to -500 and 500 but not store the -500 and 500 (as it auto stores whenever ratingMin and ratingMax is changed) because whenever we switch to a normal variant I can set the slider to what the user had previously set as.
ui/lobby/src/setupCtrl.ts
Outdated
| this.enforcePropRules(); | ||
| this.savePropsToStore(); | ||
| if (this.root.data.ratingMap && this.selectedPerf() && this.root.data.ratingMap[this.selectedPerf()].prov) { |
There was a problem hiding this comment.
The if statement checks are required because then it gives a null value error
| // Check if the rating is provisional | ||
| if (ctrl.data.ratingMap[setupCtrl.selectedPerf()].prov) { | ||
| setupCtrl.ratingMin(-500); // Set ratingMin to -500 for provisional rating | ||
| setupCtrl.ratingMax(500); |
There was a problem hiding this comment.
that code doesn't belong in the view layer
There was a problem hiding this comment.
Removed code from view layer
added 2 commits
May 31, 2023 11:08
* master: (59 commits) Revert "fewer dom text nodes and more css tricks" only feature swiss tournaments where players actually play scala tweaks scala tweaks New Crowdin updates (lichess-org#12949) tweak audio context handling voice mic selector prevent lichess.storage race condition on init moveCtrl is available remove ui/voice `let moveCtrl` global move voice toggle code out of the event listener mic.ts: if the audio context is suspended, wait for user interaction use OpaqueInt+Int=OpaqueInt Use fullMoveNumber when writing played moves Revert RendererActor visibility make RoundSocket round robin listen to 16 channels scala tweaks fewer dom text nodes and more css tricks only bind one click for all top players of a team battle remove superfluous team battle tag attr ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix for issue #12801
I fixed it such that whenever a variant where rating is provisional is switched it sets slider to -500 and 500. Whenever a switch is made back to a variant where rating is not provisional, then it sets the slider to the previous stored value stored in JSON. This is my first time contributing so please help me become better by leaving detailed feedback. Thanks!