-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
relay stats WIP #15565
relay stats WIP #15565
Conversation
allanjoseph98
commented
Jun 19, 2024
•
edited
Loading
edited
- All rounds in one (24 hour graph)
- Peak viewers
- Fill in the gap when the gap is>1 minute.
I can't seem to display viewers, using this dataset:
No errors in the console. |
export default function initModule(data: RelayStats) {
data = { rounds: data.rounds.slice(4, 5) }; This makes it work, so it's something about the other rounds that makes it fail. |
It always select the last round to make the chart. The last round is empty until the tournament is fully over. const makeChart = (data: RelayStats, $el: Cash) => {
const last = data.rounds[data.rounds.length - 1];
const ds = makeDataset(last, $el[0] as HTMLCanvasElement); |
Stupid of me. Will rework |
looks like this branch introduces a new lint warning
and this doesn't help declare module 'chart.js' {
// eslint-disable-next-line @typescript-eslint/no-unused-vars
interface PluginOptionsByType<TType extends ChartType> { because the warrning is about the generated |
This is already very useful as is, so I'm going to deploy it tomorrow. |