fix: fix deserialization of unions if the type of a field with the same name differs between union members #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me name differs between union members
|
@george-zubrienko would be great if this could be merged and a new release made. Otherwise I am staring down the barrel of having to publish our fork on pypi and updating our dependency usage to that as its a blocking issue on our side for customers that have SSE use cases in the AI space |
george-zubrienko
approved these changes
Feb 1, 2024
|
@TristanSpeakEasy should be available in 0.6.4 |
|
Great thank you |
renovate bot
added a commit
to ixm-one/pytest-cmake-presets
that referenced
this pull request
Feb 1, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [dataclasses-json](https://togithub.com/lidatong/dataclasses-json) ([changelog](https://togithub.com/lidatong/dataclasses-json/releases)) | `0.6.3` -> `0.6.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>lidatong/dataclasses-json (dataclasses-json)</summary> ### [`v0.6.4`](https://togithub.com/lidatong/dataclasses-json/releases/tag/v0.6.4) [Compare Source](https://togithub.com/lidatong/dataclasses-json/compare/v0.6.3...v0.6.4) #### What's Changed - fix: fix deserialization of unions if the type of a field with the same name differs between union members by [@​TristanSpeakEasy](https://togithub.com/TristanSpeakEasy) in [lidatong/dataclasses-json#511 #### New Contributors - [@​TristanSpeakEasy](https://togithub.com/TristanSpeakEasy) made their first contribution in [lidatong/dataclasses-json#511 **Full Changelog**: lidatong/dataclasses-json@v0.6.3...v0.6.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ixm-one/pytest-cmake-presets). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of union that failed is documented in the test I added, but basically if members of a union differed by the type of a field with a matching name, the resultant
AttributeErrorwasn't being caught and so deserialization would stop and not all the members of the union would be tried