PE from scratch seems to have section headers shifted

[ZehMatt]

Describe the bug
Building a PE from scratch like the Python example seems to have some issue with the output, it seems that the section headers are slightly shifted by a few bytes, I had a brief look at it but I couldn't spot the issue so far.

Virtual size holds 4 bytes of the name, raw address is virtual address and so on.

To Reproduce
Steps to reproduce the behavior:

        const uint64_t imageBase = 0x00400000;
        const uint64_t firstSectRVA = 0x1000;

        LIEF::PE::Binary binary("output", LIEF::PE::PE_TYPE::PE32_PLUS);
        binary.optional_header().imagebase(imageBase);

        // Add 3 sections
        uint64_t sectRVA = firstSectRVA;
        for (int i = 0; i < 3; i++)
        {
            std::vector<uint8_t> sectBuf;
            sectBuf.resize(0x200);

            LIEF::PE::Section newSect(".text" + std::to_string(i));
            newSect.content(sectBuf);
            newSect.virtual_address(sectRVA);
            newSect.virtual_size(0x900);

            newSect.add_characteristic(LIEF::PE::SECTION_CHARACTERISTICS::IMAGE_SCN_CNT_CODE);
            newSect.add_characteristic(LIEF::PE::SECTION_CHARACTERISTICS::IMAGE_SCN_MEM_EXECUTE);
            newSect.add_characteristic(LIEF::PE::SECTION_CHARACTERISTICS::IMAGE_SCN_MEM_READ);

            sectRVA += 0x1000;

            binary.add_section(newSect);
        }

        LIEF::PE::Builder builder(binary);

        builder.build();
        builder.write("test.exe");

Expected behavior
Maybe I'm not using the API correctly but the headers should be at the correct position, I'm also building this using x64 if that's relevant.

Environment (please complete the following information):

• Windows
• PE32-Plus
• Commit: c52a398

Additional context
Produced output file
test.zip

[ZehMatt]

I figured out why the tool doesn't properly show the sections, in the file header SizeOfOptionalHeader seems to be wrong, its set to 00E8 but should be 00F0

[ZehMatt]

Further investigation seems that details::DEFAULT_NUMBER_DATA_DIRECTORIES is 15 but it should be 16, there are 16 data directories in the PE and it also does add 16 in total so thats why the computation is off.

[immortalp0ny]

@ZehMatt Did you find the way how to handle it ?

[ZehMatt]

The bug should be fixed, see #734